Skip to content

Commit

Permalink
Use better naming for dual proxy
Browse files Browse the repository at this point in the history
  • Loading branch information
msujew committed Oct 25, 2023
1 parent 604a52d commit 12fc0b4
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions packages/core/src/browser/frontend-application-module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ export const frontendApplicationModule = new ContainerModule((bind, _unbind, _is

bind(SelectionService).toSelf().inSingletonScope();
bind(CommandRegistry).toSelf().inSingletonScope().onActivation(({ container }, registry) => {
WebSocketConnectionProvider.createDualProxy(container, commandServicePath, registry);
WebSocketConnectionProvider.createHandler(container, commandServicePath, registry);
return registry;
});
bind(CommandService).toService(CommandRegistry);
Expand All @@ -268,7 +268,7 @@ export const frontendApplicationModule = new ContainerModule((bind, _unbind, _is

bindMessageService(bind).onActivation(({ container }, messages) => {
const client = container.get(MessageClient);
WebSocketConnectionProvider.createDualProxy(container, messageServicePath, client);
WebSocketConnectionProvider.createHandler(container, messageServicePath, client);
return messages;
});

Expand Down Expand Up @@ -296,7 +296,7 @@ export const frontendApplicationModule = new ContainerModule((bind, _unbind, _is
bind(QuickAccessContribution).toService(QuickHelpService);

bind(QuickPickService).to(QuickPickServiceImpl).inSingletonScope().onActivation(({ container }, quickPickService: QuickPickService) => {
WebSocketConnectionProvider.createDualProxy(container, quickPickServicePath, quickPickService);
WebSocketConnectionProvider.createHandler(container, quickPickServicePath, quickPickService);
return quickPickService;
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export class WebSocketConnectionProvider extends AbstractConnectionProvider<WebS
return container.get<WebSocketConnectionProvider>(LocalWebSocketConnectionProvider).createProxy<T>(path, arg);
}

static createDualProxy(container: interfaces.Container, path: string, arg?: object): void {
static createHandler(container: interfaces.Container, path: string, arg?: object): void {
const remote = container.get(WebSocketConnectionProvider);
const local = container.get<WebSocketConnectionProvider>(LocalWebSocketConnectionProvider);
remote.createProxy(path, arg);
Expand Down
2 changes: 1 addition & 1 deletion packages/monaco/src/browser/monaco-frontend-module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ export default new ContainerModule((bind, unbind, isBound, rebind) => {

bind(MonacoQuickInputImplementation).toSelf().inSingletonScope();
bind(MonacoQuickInputService).toSelf().inSingletonScope().onActivation(({ container }, quickInputService: MonacoQuickInputService) => {
WebSocketConnectionProvider.createDualProxy(container, quickInputServicePath, quickInputService);
WebSocketConnectionProvider.createHandler(container, quickInputServicePath, quickInputService);
return quickInputService;
});
bind(QuickInputService).toService(MonacoQuickInputService);
Expand Down

0 comments on commit 12fc0b4

Please sign in to comment.