Address Review Comments #12713

eclipse-theia · Aug 7, 2023 · 3427e1a · 3427e1a
1 parent d98021b
commit 3427e1a
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/packages/preferences/src/browser/views/components/preference-select-input.ts b/packages/preferences/src/browser/views/components/preference-select-input.ts
@@ -29,14 +29,15 @@ import { escapeInvisibleChars } from '@theia/core/lib/common/strings';
 export class PreferenceSelectInputRenderer extends PreferenceLeafNodeRenderer<JSONValue, HTMLDivElement> {
 
     protected readonly selectComponent = React.createRef<SelectComponent>();
-    protected readonly selectOptions: SelectOption[] = [];
+
+    protected selectOptions: SelectOption[] = [];
 
     protected get enumValues(): JSONValue[] {
         return this.preferenceNode.preference.data.enum!;
     }
 
     protected updateSelectOptions(): void {
-        this.selectOptions.splice(0);
+        const updatedSelectOptions: SelectOption[] = [];
         const values = this.enumValues;
         const preferenceData = this.preferenceNode.preference.data;
         const defaultValue = preferenceData.default;
@@ -52,14 +53,15 @@ export class PreferenceSelectInputRenderer extends PreferenceLeafNodeRenderer<JS
                 enumDescription = this.markdownRenderer.renderInline(markdownEnumDescription);
                 markdown = true;
             }
-            this.selectOptions.push({
+            updatedSelectOptions.push({
                 label,
                 value: stringValue,
                 detail,
                 description: enumDescription,
                 markdown
             });
         }
+        this.selectOptions = updatedSelectOptions;
     }
 
     protected createInteractable(parent: HTMLElement): void {