fix ai-settings retrieval (#14221)

The languageModelRequirements can be undefined and this needs to be correcly handled by callers.
eclipse-theia · Sep 26, 2024 · 81ba5a8 · 81ba5a8
1 parent 1a7486e
commit 81ba5a8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/ai-core/src/browser/ai-configuration/language-model-renderer.tsx b/packages/ai-core/src/browser/ai-configuration/language-model-renderer.tsx
@@ -31,7 +31,7 @@ export const LanguageModelRenderer: React.FC<LanguageModelSettingsProps> = (
 
     const findLanguageModelRequirement = async (purpose: string): Promise<LanguageModelRequirement | undefined> => {
         const requirementSetting = await aiSettingsService.getAgentSettings(agent.id);
-        return requirementSetting?.languageModelRequirements.find(e => e.purpose === purpose);
+        return requirementSetting?.languageModelRequirements?.find(e => e.purpose === purpose);
     };
 
     const [lmRequirementMap, setLmRequirementMap] = React.useState<Record<string, LanguageModelRequirement>>({});

diff --git a/packages/ai-core/src/browser/frontend-language-model-registry.ts b/packages/ai-core/src/browser/frontend-language-model-registry.ts
@@ -288,7 +288,7 @@ export class FrontendLanguageModelRegistryImpl
 
     override async selectLanguageModels(request: LanguageModelSelector): Promise<LanguageModel[]> {
         await this.initialized;
-        const userSettings = (await this.settingsService.getAgentSettings(request.agent))?.languageModelRequirements.find(req => req.purpose === request.purpose);
+        const userSettings = (await this.settingsService.getAgentSettings(request.agent))?.languageModelRequirements?.find(req => req.purpose === request.purpose);
         if (userSettings?.identifier) {
             const model = await this.getLanguageModel(userSettings.identifier);
             if (model) {

diff --git a/packages/ai-core/src/common/settings-service.ts b/packages/ai-core/src/common/settings-service.ts
@@ -28,6 +28,6 @@ export interface AISettingsService {
 }
 export type AISettings = Record<string, AgentSettings>;
 export interface AgentSettings {
-    languageModelRequirements: LanguageModelRequirement[];
-    enable: boolean;
+    languageModelRequirements?: LanguageModelRequirement[];
+    enable?: boolean;
 }