fix iframe height

Signed-off-by: Jonah Iden <[email protected]>
eclipse-theia · Oct 8, 2024 · f8e8401 · f8e8401
1 parent 6c03afa
commit f8e8401
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/packages/plugin-ext/src/main/browser/notebooks/renderers/cell-output-webview.tsx b/packages/plugin-ext/src/main/browser/notebooks/renderers/cell-output-webview.tsx
@@ -462,13 +462,18 @@ export class CellOutputWebviewImpl implements CellOutputWebview, Disposable {
                 if (selectedCell) {
                     this.notebook.setSelectedCell(selectedCell);
                 }
+                break;
             case 'cellHeightRequest':
                 const cellHeight = this.notebook.getCellByHandle(message.cellHandle)?.cellHeight ?? 0;
                 this.webviewWidget.sendMessage({
                     type: 'cellHeightUpdate',
                     cellHandle: message.cellHandle,
                     height: cellHeight
                 });
+                break;
+            case 'bodyHeightChange':
+                this.webviewWidget.setIframeHeight(message.height);
+                break;
         }
     }
 

diff --git a/packages/plugin-ext/src/main/browser/notebooks/renderers/output-webview-internal.ts b/packages/plugin-ext/src/main/browser/notebooks/renderers/output-webview-internal.ts
@@ -789,5 +789,12 @@ export async function outputWebviewPreload(ctx: PreloadContext): Promise<void> {
 
     window.addEventListener('focusout', (event: FocusEvent) => focusChange(event, false));
 
+    new ResizeObserver(() => {
+        theia.postMessage({
+            type: 'bodyHeightChange',
+            height: document.body.clientHeight
+        } as webviewCommunication.BodyHeightChange);
+    }).observe(document.body);
+
     theia.postMessage(<webviewCommunication.WebviewInitialized>{ type: 'initialized' });
 }
diff --git a/packages/plugin-ext/src/main/browser/notebooks/renderers/webview-communication.ts b/packages/plugin-ext/src/main/browser/notebooks/renderers/webview-communication.ts
@@ -151,14 +151,20 @@ export interface CellHeightRequest {
     readonly cellHandle: number;
 }
 
+export interface BodyHeightChange {
+    readonly type: 'bodyHeightChange';
+    readonly height: number;
+}
+
 export type FromWebviewMessage = WebviewInitialized
     | OnDidRenderOutput
     | WheelMessage
     | CustomRendererMessage
     | KernelMessage
     | InputFocusChange
     | CellOuputFocus
-    | CellHeightRequest;
+    | CellHeightRequest
+    | BodyHeightChange;
 
 export interface Output {
     id: string