Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook API Support #12442

Merged
merged 94 commits into from
Aug 31, 2023
Merged

Notebook API Support #12442

merged 94 commits into from
Aug 31, 2023

Commits on Aug 23, 2023

  1. Add notebook package to Theia

    msujew authored and jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    b17fe8a View commit details
    Browse the repository at this point in the history
  2. working getting notebook contributions

    + can handle for openHandler
    
    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    e60b44f View commit details
    Browse the repository at this point in the history
  3. working onNotebook activation event;

    better can handle function
    
    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    0e5f2b6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c84990b View commit details
    Browse the repository at this point in the history
  5. render messaging rpc api

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    a98e3b1 View commit details
    Browse the repository at this point in the history
  6. basic widget for notebooks working

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    76bf6e8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    77230ba View commit details
    Browse the repository at this point in the history
  8. fixed activating serializers before opening notebook document; added …

    …onDirty and onSave listeners
    
    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    0f0d9dc View commit details
    Browse the repository at this point in the history
  9. notebook document dirty and save listeners

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    63ff3eb View commit details
    Browse the repository at this point in the history
  10. document dirty and save listeners

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    a450866 View commit details
    Browse the repository at this point in the history
  11. baisc saving of notebooks implemented

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    ecadf6c View commit details
    Browse the repository at this point in the history
  12. basic toolbar implementation for selected cell

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    ba6ca53 View commit details
    Browse the repository at this point in the history
  13. notebook edit framework and edit and delete actions

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    2c989f1 View commit details
    Browse the repository at this point in the history
  14. context key basics

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    a301b32 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    d0e5726 View commit details
    Browse the repository at this point in the history
  16. fixed saving

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    ff50115 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    6ffcbd4 View commit details
    Browse the repository at this point in the history
  18. basic add cell buttons (no functionality)

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3e09a16 View commit details
    Browse the repository at this point in the history
  19. all smaller review comments

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3f3ea80 View commit details
    Browse the repository at this point in the history
  20. notebookModel and notebookCellModel injectable

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    409f36d View commit details
    Browse the repository at this point in the history
  21. better dependency injection for notebookEditor widget and the cell re…

    …nderers
    
    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    2df5b29 View commit details
    Browse the repository at this point in the history
  22. fixed activation events. explicit onNotebook, implicit on NotebookSer…

    …ializer
    
    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    6513d4f View commit details
    Browse the repository at this point in the history
  23. correct dirty change after saving

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    d493d0b View commit details
    Browse the repository at this point in the history
  24. updated notebook package to 1.36.0

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    c675a88 View commit details
    Browse the repository at this point in the history
  25. removed uneccessary comment

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    82f20d6 View commit details
    Browse the repository at this point in the history
  26. react key for cellDivider

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    7461bd9 View commit details
    Browse the repository at this point in the history
  27. removed duplicate interface

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    04f6830 View commit details
    Browse the repository at this point in the history
  28. update notebook packege to 1.37.0

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    edf747c View commit details
    Browse the repository at this point in the history
  29. review comments

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    43e9058 View commit details
    Browse the repository at this point in the history
  30. stop using createInline()

     use custom lightweight creation instead
    
    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    157b49e View commit details
    Browse the repository at this point in the history
  31. more review comment changes:

    Deleted unused CellRangeMethods
    Added NotebookEditorsMain (without impl)
    
    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    c19dd8c View commit details
    Browse the repository at this point in the history
  32. renamed Event

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    80deb5e View commit details
    Browse the repository at this point in the history
  33. updated version to 1.38.0

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    7870a2b View commit details
    Browse the repository at this point in the history
  34. basics for notebook ContextKeys implemented

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    39a299b View commit details
    Browse the repository at this point in the history
  35. context keys working for cells

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    73321be View commit details
    Browse the repository at this point in the history
  36. cell toolbar menu item order; fixed cell editor sizing

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    9c4b12b View commit details
    Browse the repository at this point in the history
  37. added basic logic for adding new cells

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    c394140 View commit details
    Browse the repository at this point in the history
  38. fixed file headers

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    b6529ca View commit details
    Browse the repository at this point in the history
  39. include vscode.ipynb by default

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    0b9fc42 View commit details
    Browse the repository at this point in the history
  40. basiscs for notebook cell Execution API

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3809ce2 View commit details
    Browse the repository at this point in the history
  41. basic api for cell execution and jupyter extension support

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    a3b01e4 View commit details
    Browse the repository at this point in the history
  42. basic kernel creation and selection

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    77ca418 View commit details
    Browse the repository at this point in the history
  43. increased version to 1.39.0

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    021a227 View commit details
    Browse the repository at this point in the history
  44. basic showing cell outputs

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    8e5a462 View commit details
    Browse the repository at this point in the history
  45. cleanup, correct cell updating and basic api for notebook-edits (not …

    …fully implemented yet)
    
    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    7247029 View commit details
    Browse the repository at this point in the history
  46. fixed Element already has context attribute Error

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    928161c View commit details
    Browse the repository at this point in the history
  47. fixed cell document odes allready exists error

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3195f48 View commit details
    Browse the repository at this point in the history
  48. fixed notebook not scrollable when mouse in editor

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    35849da View commit details
    Browse the repository at this point in the history
  49. api and contributions for notebook renderers

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    6e3079e View commit details
    Browse the repository at this point in the history
  50. Improve editor performance

    msujew authored and jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    cb7dc84 View commit details
    Browse the repository at this point in the history
  51. basic cell rendering in iframes working

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    cdd8739 View commit details
    Browse the repository at this point in the history
  52. actually fixed document allready exists error

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    7ea5f8f View commit details
    Browse the repository at this point in the history
  53. only display output webview when outputs

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3a7f070 View commit details
    Browse the repository at this point in the history
  54. some fixes for displaying outputs

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    a1f5f8c View commit details
    Browse the repository at this point in the history
  55. Configuration menu
    Copy the full SHA
    d237e9e View commit details
    Browse the repository at this point in the history
  56. Configuration menu
    Copy the full SHA
    49ec33c View commit details
    Browse the repository at this point in the history
  57. smaller output layouting changes

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    f37cce4 View commit details
    Browse the repository at this point in the history
  58. added sidebar menu for cells

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    8e08f1c View commit details
    Browse the repository at this point in the history
  59. Configuration menu
    Copy the full SHA
    098077d View commit details
    Browse the repository at this point in the history
  60. Fix notebook widget startup rendering

    msujew authored and jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    0545249 View commit details
    Browse the repository at this point in the history
  61. working sidebar and change presentation for outputs

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    ac5244a View commit details
    Browse the repository at this point in the history
  62. merge issue fixes

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    f6ca0dd View commit details
    Browse the repository at this point in the history
  63. quickfix for ouput action menu

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    4220260 View commit details
    Browse the repository at this point in the history
  64. small fix for ouput webview horizontal size

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    e62a686 View commit details
    Browse the repository at this point in the history
  65. fix for previous css fix

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    a1ed1ca View commit details
    Browse the repository at this point in the history
  66. save outputs and notebook dirty on output change

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    65b58bf View commit details
    Browse the repository at this point in the history
  67. basic cell status view (still kind of bugged

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    1233170 View commit details
    Browse the repository at this point in the history
  68. fixed notebook code-cell status-bar

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    e2f5699 View commit details
    Browse the repository at this point in the history
  69. renamed Dto methods since they dont

    actually create DTOs but just Data objects that easily can be converted to the DTO
    
    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    9cbf5ac View commit details
    Browse the repository at this point in the history
  70. Configuration menu
    Copy the full SHA
    13e5746 View commit details
    Browse the repository at this point in the history
  71. basic notebook toolbar

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    7b18f0f View commit details
    Browse the repository at this point in the history
  72. working kernel chooser

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    305f4fc View commit details
    Browse the repository at this point in the history
  73. persisting kernel selection

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    1880a57 View commit details
    Browse the repository at this point in the history
  74. upgraded notebook to 1.40

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    c02e5a6 View commit details
    Browse the repository at this point in the history
  75. fixed no document error with adding new code cell;

    implemented more notebook-api;
    
    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    26b2324 View commit details
    Browse the repository at this point in the history
  76. added notebook/cell/execution contribution menu;

    Fixed execution bug with auto assign kernels
    
    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    f00e110 View commit details
    Browse the repository at this point in the history
  77. basic undo redo for notebook-editor

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3c1664a View commit details
    Browse the repository at this point in the history
  78. fixes for setting current active editor

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    fbf1662 View commit details
    Browse the repository at this point in the history
  79. added drag and drop moving of cells

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    976741c View commit details
    Browse the repository at this point in the history
  80. Set editor dirty on any edit operation

    msujew authored and jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    1527850 View commit details
    Browse the repository at this point in the history
  81. Fix formatting

    msujew authored and jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    55a5435 View commit details
    Browse the repository at this point in the history
  82. Fix notebook editor resize behavior

    msujew authored and jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    04859d7 View commit details
    Browse the repository at this point in the history
  83. Fix broken monaco editor

    msujew authored and jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    474faf9 View commit details
    Browse the repository at this point in the history
  84. removed @stubbed for most of notebook-api;

    implemented more of the api;
    
    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    9cb19ff View commit details
    Browse the repository at this point in the history
  85. fixed build for api changes

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    6a0a3b9 View commit details
    Browse the repository at this point in the history
  86. fixed lint

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    374dcdb View commit details
    Browse the repository at this point in the history
  87. basics for creating new untitled notebooks

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    ab1727a View commit details
    Browse the repository at this point in the history
  88. Fix issues after latest commit

    msujew authored and jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    e8dd288 View commit details
    Browse the repository at this point in the history
  89. Don't cache matched notebook types

    msujew authored and jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    0ef597d View commit details
    Browse the repository at this point in the history
  90. fixed multiple smaller issues

    (see eclipse-theia#12442 (review))
    
    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    f3a031c View commit details
    Browse the repository at this point in the history
  91. basic wokring creating new empty notebook;

    issues:
    sometimes no document exists
    saving as  is not working
    
    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    6409051 View commit details
    Browse the repository at this point in the history
  92. basic saveAs functionality for untitle notebooks

    Signed-off-by: Jonah Iden <[email protected]>
    jonah-iden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    a89eb2e View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Configuration menu
    Copy the full SHA
    b7fcb31 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Fix notebook header rendering

    msujew committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9add50f View commit details
    Browse the repository at this point in the history