Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[remote] Support download of native dependencies #12599

Conversation

jonah-iden
Copy link
Contributor

@jonah-iden jonah-iden commented Jun 8, 2023

What it does

This is a part of the Remote SSH feature #12390.
This PR is supposed to solve the problem of needing different native dependencies when copying the backend to a remote machine with a different OS or cpu-architecture.
As discussed in the theia-dev meeting on 6.6.23 these nativ dependencies should be included as assets in the respective theia release.

How to test

Its kind of hard to test since the rest of the feature is not yet integrated or used by anything.

The Github Actions workflow file is also deployed here for testing.
For testing the download contributions, it's probably easiest to create a small BackendApplicationContribution in the remote package and execute the NativeDependencyDownloadService downloadDependencies in onStart() in there like this:

@injectable()
export class TestBackendContrib implements BackendApplicationContribution {
    @inject(DependencyDownloadService) service: DependencyDownloadService;
    onStart(): void {
        this.service.downloadDependencies(`${process.platform}-${process.arch}`);
    }
}

After that at least for rigrep (all other dependencies are not yet deployed so yet so it kind of download the website). Through debugging you could see that they are downloaded. or maybe writing the to the file system

Review checklist

Reminder for reviewers

@msujew msujew changed the title Jiden/remote feature download nativ deps [remote] Support download of native dependencies Jun 8, 2023
@msujew msujew added the remote-ssh issues related to the ssh remote functionality label Jun 8, 2023
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
@jonah-iden jonah-iden marked this pull request as ready for review June 9, 2023 09:34
@msujew msujew added remote issues related to the remote functionality and removed remote-ssh issues related to the ssh remote functionality labels Jun 13, 2023
@msujew
Copy link
Member

msujew commented Jun 18, 2023

We've decided to integrate this change directly into #12618. I'll close this PR in favor of the other one.

@msujew msujew closed this Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remote issues related to the remote functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants