Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keybinding: Action Button Recenter #12675

Merged

Conversation

FernandoAscencio
Copy link
Contributor

After Editing keybinding, the reset button is half hidden.
This commit should properly center the keybinding action buttons.

What it does

BEFORE
image
image

AFTER
image
image

How to test

  1. Open Theia
  2. Change a keybinding.
  3. Check that the reset button to default button is half hidden

Review checklist

Reminder for reviewers

After Editing keybindding the reset button is half hidden.
This commit should properly center the keybidding action buttons.

Signed-Off-By: FernandoAscencio <[email protected]>
@vince-fugnitto vince-fugnitto added keybindings issues related to keybindings ui/ux issues related to user interface / user experience labels Jul 6, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated stylings look good to me 👍

@vince-fugnitto vince-fugnitto merged commit 41c6d9f into eclipse-theia:master Jul 18, 2023
7 checks passed
@vince-fugnitto vince-fugnitto deleted the fa/keybindActionRecenter branch July 18, 2023 16:55
@vince-fugnitto vince-fugnitto added this to the 1.40.0 milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keybindings issues related to keybindings ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants