Fix ignored resource in backend bundling #12681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flexibrah
approved these changes
Aug 8, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #12680
Related to an issue we've also encountered in Theia Blueprint, eclipse-theia/theia-blueprint#275.
For some reason, webpack finds a direct reference between
@vscode/proxy-agentand@vscode/windows-ca-certs/build/Release/crypt32.nodein some adopter projects - even though there is none. This change ensures that the dependency is correctly skipped on non-Windows systems, as the dependency is only installed/needed on Windows.Also removes a few unnecessary
yarn rebuildcalls.How to test
Confirm that the set of
ignoredResourcesis the same as in the blueprint PR eclipse-theia/theia-blueprint#275.Review checklist
Reminder for reviewers