Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add handling of extension visibility #12719

Conversation

erezmus
Copy link
Contributor

@erezmus erezmus commented Jul 18, 2023

What it does

Adds support for initial visibility of view contributions in extension as implemented by vscode (see microsoft/vscode#102002)

How to test

Install a plugin that with view contributions where the "visibility" property set to either "hidden", "visible" or "collapsed"

Review checklist

Reminder for reviewers

@tsmaeder tsmaeder requested a review from msujew July 26, 2023 09:11
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erezmus Can you provide an example extension (or an easily installable extension from the ovsx marketplace) for us to test? The test instructions are very bare-bones as they are.

@msujew msujew added the vscode issues related to VSCode compatibility label Jul 26, 2023
@msujew
Copy link
Member

msujew commented Aug 14, 2023

@erezmus Ping! Please provide further test instructions. I'll close this PR in a few days if there's no activity.

@msujew msujew closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants