Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keybindings: add context menu to keyboard shortcuts #12791

Merged
merged 7 commits into from
Oct 21, 2023
Merged

keybindings: add context menu to keyboard shortcuts #12791

merged 7 commits into from
Oct 21, 2023

Commits on Aug 1, 2023

  1. keybindings: add context menu to keyboard shortcuts 

    Fixes the bulk of eclipse-theia#7582.

Adds a context menu to the Keyboard Shorcuts editor
with the following menu items:

- Copy
- Copy Command ID
- Copy Command Title
- Edit Keybinding...
- Edit When Expression...
- Add Keybinding...
- Remove Keybinding
- Reset Keybinding
- Show Same Keybindings

This commit does not address the bonus part of eclipse-theia#7582,
i.e. no keybindings are provided for the menu items.
    @pisv
    pisv committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    1427c3c View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Merge branch 'master' into eclipse-theiaGH-7582

    @pisv
    pisv committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    d63efc5 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Merge branch 'master' into eclipse-theiaGH-7582

    @pisv
    pisv committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    7f1762b View commit details
    Browse the repository at this point in the history

  2. Address review comments 

    Removed excessive `public` modifiers and `setTimeout` call.
    @pisv
    pisv committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    fd6e4c6 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Merge branch 'master' into eclipse-theiaGH-7582

    @pisv
    pisv committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    55962fd View commit details
    Browse the repository at this point in the history

  2. Address review comments 

    Added a label for each of the new commands.
    @pisv
    pisv committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    13bc6f5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into eclipse-theiaGH-7582

    @pisv
    pisv committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    24d8a2d View commit details
    Browse the repository at this point in the history