feat: remove sync fs calls from backend+plugin code
#12798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
added
performance
|
|
kittaakos
changed the title
kittaakos
force-pushed
the
async-plugin-scanner
branch
4 times, most recently
from
186037c
to
3f22333
Compare
added 4 commits
August 4, 2023 16:29
Signed-off-by: Akos Kitta <[email protected]>
Signed-off-by: Akos Kitta <[email protected]>
Signed-off-by: Akos Kitta <[email protected]>
Signed-off-by: Akos Kitta <[email protected]>
kittaakos
force-pushed
the
async-plugin-scanner
branch
from
3f22333
to
7a89cec
Compare
kittaakos
changed the title
fs calls from backend+plugin code
msujew
reviewed
Aug 7, 2023
packages/plugin-ext-vscode/src/node/plugin-vscode-directory-handler.ts
Outdated
Show resolved
Hide resolved
packages/plugin-ext/src/main/node/paths/plugin-paths-service.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Mark Sujew <[email protected]>
to handle any error gracefully in the same catch block Signed-off-by: Akos Kitta <[email protected]>
changed return try to `Promise<void>` Signed-off-by: Akos Kitta <[email protected]>
|
Great review, Mark. Thank you! |
msujew
approved these changes
Aug 8, 2023
Co-authored-by: Mark Sujew <[email protected]>
Signed-off-by: Akos Kitta <[email protected]>
|
@msujew Could you merge? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Read plugin contributions asynchronously to avoid blocking and improve backend application startup.
Changed
PluginScanner#getContributionfrom sync to async. TheprotectedTheia and grammar scanner APIs were affected: they have been adjusted to async.I have noticed loading all the translations and contributions takes half a second in a downstream project:
This PR removes all sync
fscalls ingit,siw, andworkspaceextensions.How to test
VS Code extensions still load, and all works fine.
Review checklist
Reminder for reviewers