Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump API version to 1.80.0 #12866

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

tsmaeder
Copy link
Contributor

Contributed on behalf of ST Microelectronics

What it does

fixes #12865

How to test

Make sure the system starts and built-ins work as expected

Review checklist

Reminder for reviewers

Contributed on behalf of ST Microelectronics

Signed-off-by: Thomas Mäder <[email protected]>
Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a short check with the 1.79 built-ins.
The only thing I noticed is that the toolbar for markdown files shows two "Open Preview to the side" items, one of them showing the shortcut as well. But it looks like this was reproducible for 1.40 as well. Is this known already?
Otherwise I also installed the vsix-es from the PRs for the new VSCode API and those work as well.

@tsmaeder
Copy link
Contributor Author

Otherwise I also installed the vsix-es from the PRs for the new VSCode API and those work as well.

which PR is that?

@tsmaeder
Copy link
Contributor Author

The only thing I noticed is that the toolbar for markdown files shows two "Open Preview to the side" items, one of them showing the shortcut as well. But it looks like this was reproducible for 1.40 as well. Is this known already?

🤷

@msujew
Copy link
Member

msujew commented Aug 28, 2023

The only thing I noticed is that the toolbar for markdown files shows two "Open Preview to the side" items, one of them showing the shortcut as well. But it looks like this was reproducible for 1.40 as well. Is this known already?

@jfaltermeier I believe it's expected, since we have a preview command for markdown files in @theia/preview and a command contributed by the builtin markdown vscode extension. Both use the same codicon icon, so they appear as duplicates (but they are not the same!).

@jfaltermeier
Copy link
Contributor

Otherwise I also installed the vsix-es from the PRs for the new VSCode API and those work as well.

which PR is that?

Taken from the linked issues here #12694 the PRs are
#12836
#12838

@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Aug 28, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tsmaeder tsmaeder merged commit 8f64a58 into eclipse-theia:master Aug 29, 2023
8 checks passed
@vince-fugnitto vince-fugnitto added this to the 1.41.0 milestone Aug 31, 2023
kittaakos pushed a commit to arduino/arduino-ide that referenced this pull request Sep 12, 2023
kittaakos pushed a commit to arduino/arduino-ide that referenced this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bump API compatibility version to 1.80.0
4 participants