Notebook API post review improvements #12910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tsmaeder |
msujew
changed the title
msujew
reviewed
Sep 25, 2023
msujew
reviewed
Sep 25, 2023
packages/notebook/src/browser/contributions/notebook-cell-actions-contribution.ts
Outdated
Show resolved
Hide resolved
packages/notebook/src/browser/service/notebook-editor-widget-service.ts
Outdated
Show resolved
Hide resolved
packages/notebook/src/browser/service/notebook-editor-widget-service.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
jonah-iden
force-pushed
the
jiden/notebook-api-review-comments
branch
from
695a979
to
921c1f9
Compare
tsmaeder
requested changes
Oct 9, 2023
packages/notebook/src/browser/service/notebook-kernel-quick-pick-service.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonah Iden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This is the first batch of Review comments from #12442
I'll be making more of these smaller PRs so that they will be easier to review
How to test
here you can find a test notebook.
These review comments mostly are about loading of notebooks and cell execution
Review checklist
Reminder for reviewers