Add search history hint #12967
Merged
Add search history hint #12967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Radke <[email protected]>
Signed-off-by: Christian Radke <[email protected]>
tortmayr
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Change looks good to me.
Everything works as expected.
I can only test this under Linux and Windows. @JonasHelming Should someone confirm that the arrow icons works as expected under Mac or do we just merge this as is?
|
@tortmayr I asked Christian to have a look |
|
@tortmayr @JonasHelming I can confirm that it looks as intended on MacOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR aligns the Search and Replace textareas in the Search In Workspace widget with VSCode by adding the hint "(⇅ for history)" to the placeholder labels when the respective textarea has focus.
In addition, because the up and down arrows symbol would look off otherwise, this PR also adds a OS specific class to the body ("mac", "windows" or "linux") to set the --theia-ui-font-family variable accordingly. That behavior, as well as the CSS, was taken over from VSCode.
How to test
Open the Search In Workspace widget and click into the Search and Replace textareas. Make sure they're empty so you can see the dynamic placeholders.
Follow-ups
Review checklist
Reminder for reviewers