-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix URL path for output renderer scripts #12976
Conversation
Signed-off-by: Jonah Iden <[email protected]>
Hello @jonah-iden, we tested this solution but it's not working for us, we're getting this error now: It seems the browser import function is being finicky about relative module paths. Prefixing a |
Hi, sorry for the late reply. |
No problem. Thank you @jonah-iden. Btw another possibility to consider is that I messed something up on my end... |
Signed-off-by: Jonah Iden <[email protected]>
@bvenreply, i was able to reproduce your error and improved my previous solution. For me this works great. could you test it again if you find the time? |
@jonah-iden I tested the new changes, I confirm it's working. Thanks! |
@msujew We discussed yesterday that your approval is enough for this one to be merged |
packages/plugin-ext/src/main/browser/notebooks/renderers/output-webview-internal.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, works well. I'm not 100% sure this is the best approach to this, but it works and we can easily change it in case there are any issues.
What it does
Fixes #12966
Fixes an issue with notebook api downloading output renderer scripts from base path instead of deployed path
How to test
Easiest for me was using nginx.
Follow-ups
Review checklist
Reminder for reviewers