Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nls metadata for VSCode API 1.82.0 #13028

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Oct 26, 2023

What it does

Updates the nls metadata for the latest API bump #13025.

How to test

CI is green, no translation warnings are displayed on application startup.

Review checklist

Reminder for reviewers

@msujew msujew added the localization issues related to localization/internalization/nls label Oct 26, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vince-fugnitto vince-fugnitto merged commit e8e4700 into master Oct 26, 2023
13 checks passed
@vince-fugnitto vince-fugnitto deleted the msjuew/nls-update-1.82.0 branch October 26, 2023 17:50
@vince-fugnitto vince-fugnitto modified the milestone: 1.43.0 Oct 26, 2023
@yanquer
Copy link

yanquer commented Nov 16, 2023

why "File" will be convert to "terminal.integrated.localFileLinks" with "vs/workbench/contrib/terminalContrib/links/browser/terminalLinkQuickpick", which will be translated as “local file” as other language;

path: "core/src/common/i18n/nls.metadata.json"
line: 15219

@msujew
Copy link
Member Author

msujew commented Nov 16, 2023

@yanquer Seems like the automatic translation lookup isn't picking this up correctly. I'll see what I can do about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants