Use description field as thread stopped status. fixes #13049 #13050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3049 If thread Stopped event contains description field, UI must show description as is
|
@EvilBeaver thx for the pull request, could you please address the linter issues? |
@tsmaeder done |
is a bit much to ask from testers. Do you know or have a plugin that allows to test this? |
|
@tsmaeder The builtin JS debugger vscode extension already does this. |
|
@msujew I don't get it: when I break on a breakpoint in the Theia source code, I already get the description "ANGEHALTEN FÜR HALTEPUNKT" in the threads view. What are we fixing? |
|
@tsmaeder The js-debug extension is supposed to send "Bei Haltepunkt angehalten" in the German localization (compare with German vscode to test this). |
tsmaeder
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If thread Stopped event contains description field, UI must show description as is
What it does
Fixes #13049
How to test
Follow-ups
It would be nice to localize "Paused on {0}" text, but I'm not sure how it translates in other languages. Should it be two separate NLS keys "Paused on {0}" + "reason" (like now) or should it be single NLS key "paused on step" where word order depends on specific language.
Review checklist
Reminder for reviewers