Avoid class-name based contribution filtering #13103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
approved these changes
Nov 27, 2023
packages/core/src/common/contribution-filter/contribution-filter.ts
Outdated
Show resolved
Hide resolved
Update example to avoid class name based contribution filtering. Class names are minified in production which breaks the contribution filter. Use instance of check instead. Also mention this in the `FilterContribution` JS-Doc
tortmayr
force-pushed
the
tortmayr/contribution-filter
branch
from
e595642
to
4aba24a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Update example to avoid class name based contribution filtering. Class names are minified in production which breaks the contribution filter.
Use instance of check instead.
Also mention this in the
FilterContributionJS-DocContributed on behalf of STMicroelectronics
How to test
Open command palette and verify that the command "example_command.filtered" is still filtered out and not available.
Follow-ups
Review checklist
Reminder for reviewers