chore: polish AI code completion #14192
Merged
+86
−204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removes code completion item provider as it blocks the completion popup - reworks the code completion prompt so that it can be easier customized - catches abort errors in the Open AI Api which are triggered very often when using code completion. This avoids spamming the log with "non-errors".
1 task
eneufeld
reviewed
Sep 19, 2024
| suggestions.push(completionItem); | ||
| return { suggestions }; | ||
| } | ||
| tags?: String[] | undefined; |
There was a problem hiding this comment.
if tags is optional I think typescript automatically adds the undefined type
|
nice cleanup and code removal, I like it! Code completion still works. |
eneufeld
approved these changes
Sep 19, 2024
planger
approved these changes
Sep 19, 2024
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
How to test
Follow-ups
Review checklist
Reminder for reviewers