-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace nsfw
with @parcel/watcher
#14194
Conversation
@tsmaeder I'll be on vacation for a week starting Friday. In case you want to change anything in the PR, please feel free :) |
There is a basic scenario that seems to be broken with the new watcher:
In master, the deletion of the modules is reflected in the Theia file navigator |
Now this is interesting: it seems that |
Hi, |
@safisa It might fix the issue, yes. |
@planger Could you have a look at the failing playwright tests? The errors are not reproducible on Windows and the tests don't run for me on Ubuntu (Gitpod) for some reason. |
I've looked into the failures of the Playwright tests. They only fail on Linux. IMO, this is a bug in the "compressed tree" and is probably unrelated to the change at hand. So, with the resources folder from the playwright test, you can do the following scenario:
The same events seem to be sent on Linux and Windows, so my suspicion is that this is a reordering of async blocks du to the different timings on the respective platforms. |
Thanks for looking into this @tsmaeder! This makes sense, looking at the logs briefly. We can take a look at the failing test in more detail, but I also suspect it might be an actual UI issue on Linux. To avoid having failing tests, I would suggest skipping this failing test for now and open a new issue. |
0751e0c
to
518388b
Compare
518388b
to
2ce371d
Compare
What it does
Continuation of #12784
Closes #14015
Replaces our
nsfw
dependency with@parcel/watcher
to align with vscode.How to test
Test file watching related capabilities and confirm that there are no regressions:
settings.json
should be reflected in changes in the preferenceslaunch.json
should be reflected in the debug viewReview checklist
Reminder for reviewers