Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix css calc expression to have space around operator #14241

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented Oct 2, 2024

What it does

Fixes #14204

Contributed on behalf of STMicroelectronics

How to test

Make sure toolbar items look O.K. in browser and electron cases

Follow-ups

Review checklist

Reminder for reviewers

Fixes eclipse-theia#14204

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder tsmaeder requested a review from msujew October 2, 2024 12:56
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the doesn't lead to any regressions. In fact, it doesn't do anything, since the rule in questions is always overriden:

image

See #3864 and the code:

.theia-sidepanel-toolbar .p-TabBar-toolbar .item > div {
height: 18px;
width: 18px;
background-repeat: no-repeat;
}

Maybe we should remove the height and width attributes above?

@tsmaeder
Copy link
Contributor Author

tsmaeder commented Oct 7, 2024

The fact that we're overriding the rule does not mean that adopters are not using it. This PR is just to fix the syntax issue, I haven't really thought about the larger picture.

@tsmaeder tsmaeder merged commit 54ab65d into eclipse-theia:master Oct 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[bug] Style Error
2 participants