Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ai): Update OpenAI models supporting structured output #14247

Conversation

planger
Copy link
Contributor

@planger planger commented Oct 3, 2024

What it does

Updates the list of OpenAI models supporting structured output. As gpt-4o now points to 'gpt-4o-2024-08-06', it now also support structured output. In addition, I added 'gpt-4o-latest', which always points to the latest release and thus supports structured output too.

How to test

Configure gpt-4o to be used for the terminal agent and test the terminal agent.
You can verify if it uses structured output by setting a breakpoint in ai-terminal-agent.ts at line 182.

Follow-ups

None

Review checklist

Reminder for reviewers

Copy link
Contributor

@JonasHelming JonasHelming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Maybe we want to add "latest" to the default list, too?

@planger planger force-pushed the planger/update-openai-structured-output-models branch from ab399bc to 1f69e80 Compare October 3, 2024 11:37
@planger
Copy link
Contributor Author

planger commented Oct 3, 2024

Good point, but actually -latest doesn't seem to be available via the completion API. So it probably doesn't make sense to include it in the structured output check too. I removed it.

@JonasHelming
Copy link
Contributor

approval still valid :-)

@planger planger merged commit ac0c246 into eclipse-theia:master Oct 3, 2024
11 checks passed
@planger planger deleted the planger/update-openai-structured-output-models branch October 3, 2024 19:39
@planger planger added this to the 1.55.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants