Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize showing recent workspaces #14260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msujew
Copy link
Member

@msujew msujew commented Oct 7, 2024

What it does

I've recently noticed that attempting to execute the "Open recent workspace" command takes a few seconds on Windows. This change optimizes quite a lot of the old code to improve the performance and also fix a few issues regarding incorrectly displayed paths. In order to get the most performance out of it, I had to remove the pretty expensive FileService#resolve calls which were used to differentiate between file and directory workspaces.

How to test

  1. Run the "Open recent workspace" command.
  2. Assert that it effectively instantly opens the quick pick for the workspaces
  3. Assert that there are no regressions.

Review checklist

Reminder for reviewers

@msujew msujew added performance issues related to performance workspace issues related to the workspace labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance issues related to performance workspace issues related to the workspace
Projects
Status: Waiting on reviewers
Development

Successfully merging this pull request may close these issues.

1 participant