Optimize showing recent workspaces #14260
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
I've recently noticed that attempting to execute the "Open recent workspace" command takes a few seconds on Windows. This change optimizes quite a lot of the old code to improve the performance and also fix a few issues regarding incorrectly displayed paths. In order to get the most performance out of it, I had to remove the pretty expensive
FileService#resolve
calls which were used to differentiate between file and directory workspaces.How to test
Review checklist
Reminder for reviewers