Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed notebook editor staying current even when selecting sidebar or bottom panel #14262

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

This lets the current notebook editor stay as active in the plugin host even when selecting another widget as long as the notebook-editor is visible and no other text-editor is selected

How to test

you can find an vscoed extension here which adds an output channel to show the cahnge events. See that the active notebook editor and cell editor should stay even when selecting another non text-editor widget.

Follow-ups

This still has the same issues as the text editor active handling. For example having a text or notebook editor open and a custom editor right beside it so both are visible, then focusing the custom editor does not change the vscode api activeTextEditor or ActiveNotebookEditor

Review checklist

Reminder for reviewers

@jonah-iden jonah-iden requested a review from msujew October 7, 2024 11:47
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 👍

@jonah-iden jonah-iden merged commit 8f0f4b1 into master Oct 8, 2024
11 checks passed
@jonah-iden jonah-iden deleted the jiden/notebook-editor-current-fix branch October 8, 2024 09:38
@github-actions github-actions bot added this to the 1.55.0 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants