-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update built-ins for Open VSX publish #20
Conversation
b473a6d
to
f26427b
Compare
I am fine with it, but we should also make sure that it looks good in the registry by default to. We won't be able to fix all VS Code extensions in such way. |
f26427b
to
a11fc5b
Compare
I have refined a bit:
|
a11fc5b
to
052fa2c
Compare
@akosyakov are you fine with merging this PR? Here is the plan after:
Any objections? cc: @spoenemann |
The built-ins package.json are missing many fields that are desirable to have so that the extension's page on Open VSX will be populated correctly. Fixes #19 Signed-off-by: Marc Dumais <[email protected]>
052fa2c
to
bba52b2
Compare
What is |
That's what Microsoft apparently calls what one can build from the |
i.e. VS Code without the proprietary components and configs |
Ok, so VSCodium is an example of 👍 ok to merge from my side. |
Yes, or we could say a derivative of it. BTW, they took the decision to still include the MS Marketplace config as part of |
Merging, based on #20 (comment) and #20 (comment) |
Ok all done. |
The built-ins package.json are missing many fields that are
desirable to have so that the extension's page on Open VSX
will be populated correctly.
Fixes #19
How to test:
.vsix
from thedist
folderbuiltins
folder at the rootvscode
namespace:$> cli/lib/ovsx create-namespace vscode -r http://localhost:8080 -p super_token
$> cli/lib/ovsx publish -r http://localhost:8080 -p super_token builtins/grunt-1.40.0-prel.vsix