Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-wot: update description #2

Merged
merged 1 commit into from
Jul 25, 2023
Merged

node-wot: update description #2

merged 1 commit into from
Jul 25, 2023

Conversation

egekorkan
Copy link
Member

This updates the repository description which is currently just the name of the repo

@egekorkan egekorkan requested a review from a team as a code owner July 25, 2023 14:12
@github-actions
Copy link

Diff for 7c61edd:
Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Actions are indicated with the following symbols:
+   create
!   modify
!   forced update
-   delete

Organization eclipse-thingweb[id=eclipse-thingweb]
  there have been 4 validation infos, enable verbose output with '-v' to to display them.

  
!   repository[name="node-wot"] {
!     description                                              = "thingweb.node-wot" -> "Components for building WoT devices or for interacting with them over various IoT protocols"
    }
  
  Plan: 0 to add, 1 to change, 0 to delete.
Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Organization eclipse-thingweb[id=eclipse-thingweb]

@netomi netomi merged commit d8baf66 into eclipse-thingweb:main Jul 25, 2023
1 check passed
@netomi
Copy link
Contributor

netomi commented Jul 25, 2023

change has been applied.

@relu91
Copy link
Member

relu91 commented Jul 25, 2023

Thank you! Next time is it possible to wait for a review from at least two other project committers? Or can we define a sort of simple policy for this?

@netomi
Copy link
Contributor

netomi commented Jul 25, 2023

I am sorry, this seemed like a simple change that I approved right away. Normally, we add the project leads to PRs for approval of changes that are not that simple. I will look into ways how we can express that on an organization level that you would like to have 2 reviews from fellow committers.

@egekorkan
Copy link
Member Author

I think one project lead would be also fine. Just that I am not even an official Eclipse Committer (the election is in progress) and this could mean that a random person with Eclipse account can change such public information. In any case, it was nice to see that this pipeline works really well and thank you @netomi for the quick interactions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants