Skip to content

Commit

Permalink
Merge pull request #1321 from hasanheroglu/1319-detect-issue-with-dep…
Browse files Browse the repository at this point in the history
…endencies-in-monorepo

detect phantom dependencies and fix
  • Loading branch information
relu91 authored Aug 28, 2024
2 parents 99b8303 + 1f54133 commit daf620a
Show file tree
Hide file tree
Showing 24 changed files with 343 additions and 23 deletions.
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ module.exports = {
"@typescript-eslint/prefer-nullish-coalescing": "error",
"unused-imports/no-unused-imports": "error",
"@typescript-eslint/strict-boolean-expressions": "error",
"import/no-extraneous-dependencies": "error",
"guard-for-in": "error",
"unused-imports/no-unused-vars": [
"warn",
Expand Down
257 changes: 244 additions & 13 deletions package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/binding-coap/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"types": "dist/coap.d.ts",
"dependencies": {
"@node-wot/core": "0.8.17",
"@types/node": "16.18.35",
"coap": "^1.4.0",
"dns-packet": "^5.2.2",
"multicast-dns": "^7.2.5",
"node-coap-client": "1.0.8",
"rxjs": "5.5.11",
Expand Down
6 changes: 6 additions & 0 deletions packages/binding-coap/test/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"extends": "../.eslintrc.json",
"rules": {
"import/no-extraneous-dependencies": "off"
}
}
3 changes: 2 additions & 1 deletion packages/binding-file/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
"main": "dist/file.js",
"types": "dist/file.d.ts",
"dependencies": {
"@node-wot/core": "0.8.17"
"@node-wot/core": "0.8.17",
"rxjs": "^5.5.11"
},
"scripts": {
"build": "tsc -b",
Expand Down
6 changes: 6 additions & 0 deletions packages/binding-file/test/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"extends": "../.eslintrc.json",
"rules": {
"import/no-extraneous-dependencies": "off"
}
}
6 changes: 5 additions & 1 deletion packages/binding-http/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,20 @@
"devDependencies": {
"@node-oauth/express-oauth-server": "^3.0.1",
"@node-oauth/oauth2-server": "^4.3.0",
"@sinonjs/fake-timers": "^11.2.2",
"@types/accept-language-parser": "^1.5.2",
"@types/basic-auth": "1.1.3",
"@types/eventsource": "^1.1.10",
"@types/express": "^4.17.3",
"@types/node-fetch": "^2.5.10",
"body-parser": "^1.20.1",
"express": "^4.18.2",
"serve-static": "^1.15.0",
"ssestream": "^1.1.0",
"timekeeper": "^2.2.0"
},
"dependencies": {
"@node-wot/core": "0.8.17",
"@types/eventsource": "1.1.10",
"accept-language-parser": "1.5.0",
"basic-auth": "2.0.1",
"client-oauth2": "^4.2.5",
Expand Down
6 changes: 6 additions & 0 deletions packages/binding-http/test/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"extends": "../.eslintrc.json",
"rules": {
"import/no-extraneous-dependencies": "off"
}
}
2 changes: 1 addition & 1 deletion packages/binding-mbus/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"dependencies": {
"@node-wot/core": "0.8.17",
"node-mbus": "^2.2.4",
"wot-typescript-definitions": "0.8.0-SNAPSHOT.29"
"rxjs": "^5.5.11"
},
"scripts": {
"build": "tsc -b",
Expand Down
6 changes: 6 additions & 0 deletions packages/binding-mbus/test/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"extends": "../.eslintrc.json",
"rules": {
"import/no-extraneous-dependencies": "off"
}
}
6 changes: 6 additions & 0 deletions packages/binding-modbus/test/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"extends": "../.eslintrc.json",
"rules": {
"import/no-extraneous-dependencies": "off"
}
}
6 changes: 6 additions & 0 deletions packages/binding-mqtt/test/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"extends": "../.eslintrc.json",
"rules": {
"import/no-extraneous-dependencies": "off"
}
}
9 changes: 6 additions & 3 deletions packages/binding-netconf/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,9 @@
"types": "dist/netconf.d.ts",
"dependencies": {
"@node-wot/core": "0.8.17",
"@types/node-netconf": "npm:@types/netconf@^2.0.0",
"@types/url-parse": "^1.4.3",
"case-1.5.3": "npm:case@^1.5.3",
"node-netconf": "^1.1.2",
"rxjs": "^5.5.11",
"url-parse": "^1.5.8"
},
"scripts": {
Expand All @@ -35,5 +34,9 @@
"directories": {
"test": "test"
},
"keywords": []
"keywords": [],
"devDependencies": {
"@types/node-netconf": "npm:@types/netconf@^2.0.0",
"@types/url-parse": "^1.4.3"
}
}
6 changes: 6 additions & 0 deletions packages/binding-netconf/test/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"extends": "../.eslintrc.json",
"rules": {
"import/no-extraneous-dependencies": "off"
}
}
2 changes: 2 additions & 0 deletions packages/binding-opcua/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
},
"dependencies": {
"@node-wot/core": "0.8.17",
"ajv": "^8.11.0",
"ajv-formats": "^2.1.1",
"node-opcua": "2.113.0",
"node-opcua-address-space": "2.113.0",
"node-opcua-basic-types": "2.113.0",
Expand Down
6 changes: 6 additions & 0 deletions packages/binding-opcua/test/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"extends": "../.eslintrc.json",
"rules": {
"import/no-extraneous-dependencies": "off"
}
}
1 change: 1 addition & 0 deletions packages/binding-websockets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"dependencies": {
"@node-wot/binding-http": "0.8.17",
"@node-wot/core": "0.8.17",
"rxjs": "^5.5.11",
"slugify": "^1.4.5",
"ws": "^7.5.10"
},
Expand Down
6 changes: 6 additions & 0 deletions packages/binding-websockets/test/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"extends": "../.eslintrc.json",
"rules": {
"import/no-extraneous-dependencies": "off"
}
}
6 changes: 4 additions & 2 deletions packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"@node-wot/binding-websockets": "0.8.17",
"@node-wot/core": "0.8.17",
"@thingweb/thing-model": "^1.0.1",
"@types/lodash": "^4.14.199",
"ajv": "^8.11.0",
"commander": "^9.1.0",
"dotenv": "^8.6.0",
Expand All @@ -47,5 +46,8 @@
"url": "https://github.com/eclipse-thingweb/node-wot/issues"
},
"homepage": "https://github.com/eclipse-thingweb/node-wot/tree/master/packages/cli#readme",
"keywords": []
"keywords": [],
"devDependencies": {
"@types/lodash": "^4.14.199"
}
}
6 changes: 6 additions & 0 deletions packages/cli/test/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"extends": "../.eslintrc.json",
"rules": {
"import/no-extraneous-dependencies": "off"
}
}
4 changes: 3 additions & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"@types/content-type": "^1.1.8",
"@types/debug": "^4.1.7",
"@types/uritemplate": "^0.3.4",
"@types/uuid": "^8.3.1"
"@types/uuid": "^8.3.1",
"wot-thing-description-types": "^1.1.0-09-November-2023"
},
"dependencies": {
"@petamoriken/float16": "^3.1.1",
Expand All @@ -29,6 +30,7 @@
"content-type": "^1.0.5",
"debug": "^4.3.4",
"is-absolute-url": "3.0.3",
"rxjs": "^5.5.11",
"uritemplate": "0.3.4",
"url-toolkit": "2.1.6",
"uuid": "^7.0.3",
Expand Down
6 changes: 6 additions & 0 deletions packages/core/test/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"extends": "../.eslintrc.json",
"rules": {
"import/no-extraneous-dependencies": "off"
}
}
1 change: 1 addition & 0 deletions packages/td-tools/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"types": "dist/td-tools.d.ts",
"dependencies": {
"ajv": "^8.11.0",
"ajv-formats": "^2.1.1",
"debug": "^4.3.4",
"is-absolute-url": "3.0.3",
"json-placeholder-replacer": "^1.0.35",
Expand Down
6 changes: 6 additions & 0 deletions packages/td-tools/test/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"extends": "../.eslintrc.json",
"rules": {
"import/no-extraneous-dependencies": "off"
}
}

0 comments on commit daf620a

Please sign in to comment.