Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix action handling for no contents #1042

Merged
merged 6 commits into from
Aug 1, 2023

Conversation

relu91
Copy link
Member

@relu91 relu91 commented Jul 28, 2023

This PR tackles both problems described in #1041. In particular, now the HTTP server responds using 204 when no content is provided and the payload contains the number zero for the testing ( see 1e7b3fc).

Fix #1041

Copy link
Member

@JKRhb JKRhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @relu91, the changes look good to me :) See a couple of minor suggestions/comments below.

packages/binding-http/test/http-server-test.ts Outdated Show resolved Hide resolved
packages/binding-http/test/http-server-test.ts Outdated Show resolved Hide resolved
packages/core/src/exposed-thing.ts Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2023

Codecov Report

Merging #1042 (bc6030c) into master (567e979) will increase coverage by 0.37%.
Report is 6 commits behind head on master.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1042      +/-   ##
==========================================
+ Coverage   75.43%   75.80%   +0.37%     
==========================================
  Files          80       80              
  Lines       15185    15303     +118     
  Branches     1434     1444      +10     
==========================================
+ Hits        11455    11601     +146     
+ Misses       3697     3669      -28     
  Partials       33       33              
Files Changed Coverage Δ
packages/binding-http/src/routes/action.ts 58.58% <100.00%> (+4.04%) ⬆️
packages/core/src/exposed-thing.ts 66.91% <100.00%> (+0.14%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good.

Very minor comment below that is up to you ...

@relu91 relu91 mentioned this pull request Jul 31, 2023
14 tasks
@danielpeintner danielpeintner merged commit 0f6c5f8 into eclipse-thingweb:master Aug 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoking an action with no output over HTTP
4 participants