-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strict checking for http-binding package #1048
Conversation
a9bb7a7
to
7cdcd96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked through the code and I did not spot any issue..
Thanks for all the work!
Below a minor question...
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1048 +/- ##
==========================================
- Coverage 75.78% 75.63% -0.15%
==========================================
Files 80 80
Lines 15303 15324 +21
Branches 1444 1460 +16
==========================================
- Hits 11597 11591 -6
- Misses 3673 3699 +26
- Partials 33 34 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yet another big PR, really sorry but I couldn't make it shorter because otherwise, the code base would not even compile.
relates to #758