Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict checking for http-binding package #1048

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

relu91
Copy link
Member

@relu91 relu91 commented Aug 1, 2023

Yet another big PR, really sorry but I couldn't make it shorter because otherwise, the code base would not even compile.

relates to #758

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through the code and I did not spot any issue..

Thanks for all the work!

Below a minor question...

packages/binding-http/src/credential.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Merging #1048 (5469a3a) into master (7340a59) will decrease coverage by 0.15%.
Report is 7 commits behind head on master.
The diff coverage is 47.89%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1048      +/-   ##
==========================================
- Coverage   75.78%   75.63%   -0.15%     
==========================================
  Files          80       80              
  Lines       15303    15324      +21     
  Branches     1444     1460      +16     
==========================================
- Hits        11597    11591       -6     
- Misses       3673     3699      +26     
- Partials       33       34       +1     
Files Changed Coverage Δ
packages/binding-http/src/oauth-manager.ts 98.26% <0.00%> (-0.87%) ⬇️
packages/binding-http/src/routes/event.ts 18.51% <0.00%> (ø)
...ckages/binding-http/src/routes/property-observe.ts 20.00% <0.00%> (-0.41%) ⬇️
...kages/binding-http/src/routes/thing-description.ts 47.48% <0.00%> (-0.54%) ⬇️
...ackages/binding-http/src/oauth-token-validation.ts 93.56% <33.33%> (-1.21%) ⬇️
packages/binding-http/src/routes/action.ts 57.42% <33.33%> (+2.88%) ⬆️
packages/binding-http/src/routes/properties.ts 63.41% <42.85%> (-1.15%) ⬇️
packages/binding-http/src/routes/property.ts 66.37% <44.44%> (-1.48%) ⬇️
packages/binding-http/src/http-server.ts 83.30% <55.55%> (-1.06%) ⬇️
packages/binding-http/src/http-client-impl.ts 66.58% <63.63%> (-0.97%) ⬇️
... and 6 more

... and 1 file with indirect coverage changes

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@relu91 relu91 merged commit db4b2c1 into eclipse-thingweb:master Aug 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants