refactor: use a default contentType of application/json in Forms #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, it seems as if for this to work, the |
Note: the mentioned field is auto-generated based on the JSON Schema... |
JKRhb
force-pushed
the
form-default-content-type
branch
from
a5c9e85 to
7ab34e4
Compare
JKRhb
force-pushed
the
form-default-content-type
branch
from
7ab34e4 to
01cc16e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1175 (comment), this PR includes a proposal for making the
contentTypeof theFormclass non-nullable by defaulting toapplication/jsonwhen no Content-Type is passed to the constructor.This change has the nice effect of getting rid of a lot of nullish coalescing which is currently required to arrive at the default value which had the potential for causing some inconsistencies across the codebase.