Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip MQTT broker test on macOS #1181

Closed
wants to merge 3 commits into from

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Dec 4, 2023

This PR proposes to skip one of the MQTT tests on macOS until the underlying issue (#1159) is fixed.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8761e64) 76.66% compared to head (3e5fecc) 76.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1181      +/-   ##
==========================================
+ Coverage   76.66%   76.88%   +0.21%     
==========================================
  Files          80       80              
  Lines       16813    16813              
  Branches     1618     1618              
==========================================
+ Hits        12890    12926      +36     
+ Misses       3893     3857      -36     
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it is very annoying to see failings tests all the time.
The approach seems fine for now since we skip tests on MacOS only

@danielpeintner
Copy link
Member

@JKRhb is there a reason why it is still marked as "work in progress" ?

@danielpeintner
Copy link
Member

FYI: MQTT tests are failing on Windows also, see https://github.com/eclipse-thingweb/node-wot/actions/runs/7098842840/job/19321848426#step:8:414

@relu91
Copy link
Member

relu91 commented Dec 5, 2023

I'm working on MQTT client, let's put this on hold.

@JKRhb
Copy link
Member Author

JKRhb commented Dec 5, 2023

@JKRhb is there a reason why it is still marked as "work in progress" ?

The tests were failing somehow when I was working on them yesterday, but apparently, 3e5fecc actually resolved the issue 😅 But if you are working on an actual fix, @relu91, then we can also simply close this one – feel free to do so :)

@JKRhb
Copy link
Member Author

JKRhb commented Dec 7, 2023

I think with #1184, we can consider this one superseded :)

@JKRhb JKRhb closed this Dec 7, 2023
@JKRhb JKRhb deleted the skip-mqtt-macos branch December 7, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants