-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: skip MQTT broker test on macOS #1181
Conversation
ac9b1ca
to
80afe18
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1181 +/- ##
==========================================
+ Coverage 76.66% 76.88% +0.21%
==========================================
Files 80 80
Lines 16813 16813
Branches 1618 1618
==========================================
+ Hits 12890 12926 +36
+ Misses 3893 3857 -36
Partials 30 30 ☔ View full report in Codecov by Sentry. |
5df16db
to
5f124e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, it is very annoying to see failings tests all the time.
The approach seems fine for now since we skip tests on MacOS only
@JKRhb is there a reason why it is still marked as "work in progress" ? |
FYI: MQTT tests are failing on Windows also, see https://github.com/eclipse-thingweb/node-wot/actions/runs/7098842840/job/19321848426#step:8:414 |
I'm working on MQTT client, let's put this on hold. |
The tests were failing somehow when I was working on them yesterday, but apparently, 3e5fecc actually resolved the issue 😅 But if you are working on an actual fix, @relu91, then we can also simply close this one – feel free to do so :) |
I think with #1184, we can consider this one superseded :) |
This PR proposes to skip one of the MQTT tests on macOS until the underlying issue (#1159) is fixed.