Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): move serverKey and serverCert under http #1271

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

danielpeintner
Copy link
Member

Note: the PR also removed the following from "servient"

            "dependencies": {
                "serverKey": ["serverCert"],
                "serverCert": ["serverKey"]
            }

since

  • dependencies are now dependentRequired and dependentSchemas
  • and deals with subschemas which we don't use

Am I wrong?

fixes #839

* also removes "dependencies" term
@danielpeintner danielpeintner changed the title fix: move serverKey and serverCert under http fix(cli): move serverKey and serverCert under http Apr 23, 2024
@danielpeintner
Copy link
Member Author

Note: The MQTT tests are failing again and do not recover. I don't think it has anything to do with this PR.
https://github.com/eclipse-thingweb/node-wot/actions/runs/8800424907/job/24189040521#step:9:418

@relu91 relu91 merged commit c000311 into eclipse-thingweb:master Apr 24, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Discrepancy for HTTPS Server
3 participants