Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add td utils #32

Merged
merged 9 commits into from
Jul 12, 2024
Merged

add td utils #32

merged 9 commits into from
Jul 12, 2024

Conversation

hasanheroglu
Copy link
Contributor

Closes #18

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.23%. Comparing base (b53a2f1) to head (7c564d2).
Report is 34 commits behind head on main.

Files Patch % Lines
node/td-utils/src/detectProtocolSchemes.ts 95.12% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #32       +/-   ##
===========================================
+ Coverage   74.94%   95.23%   +20.28%     
===========================================
  Files           7        2        -5     
  Lines         986       42      -944     
  Branches      361        9      -352     
===========================================
- Hits          739       40      -699     
+ Misses        203        2      -201     
+ Partials       44        0       -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielpeintner
Copy link
Member

Question: Should we use JS or use TypeScript?

@egekorkan
Copy link
Member

egekorkan commented Jul 2, 2024

Question: Should we use JS or use TypeScript?

All should move to TS soon :) This is an adapted version of the logic in the depths of playground at https://github.com/eclipse-thingweb/playground/blob/master/packages/core/index.js#L1305

@danielpeintner
Copy link
Member

Since the code in detectProtocolSchemes.js isn't really complex we could do it right away...
Anyway it is fine by me.

@hasanheroglu
Copy link
Contributor Author

I'm on it now

@egekorkan
Copy link
Member

We had some discussion on this in the regular call:

  1. The test file should contain the expected output and not the TD
  2. The expected output should look like the following:
    "protocolSchemes": {
      "http":[{
      	"uri":"http://mylamp.example.com:8080",
        "subprotocol":"longpoll"
      },
      {
      	"uri":"http://mylamp.example.com:8081"
      }]

@egekorkan egekorkan merged commit 5f8defd into eclipse-thingweb:main Jul 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New package for td-utils
4 participants