Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: export Resolver interface #43

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

danielpeintner
Copy link
Member

fixes #35

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.06%. Comparing base (1e1c19a) to head (2b73069).

❗ There is a different number of reports uploaded between BASE (1e1c19a) and HEAD (2b73069). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (1e1c19a) HEAD (2b73069)
12 2
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   76.86%   70.06%   -6.81%     
==========================================
  Files          17        1      -16     
  Lines        1993      304    -1689     
  Branches      665       78     -587     
==========================================
- Hits         1532      213    -1319     
+ Misses        376       70     -306     
+ Partials       85       21      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielpeintner
Copy link
Member Author

Note: If nobody minds we should publish this update soon to can proceed with eclipse-thingweb/node-wot#1312.

@danielpeintner danielpeintner requested a review from egekorkan July 25, 2024 09:25
Comment on lines +2 to +3
"name": "@thingweb/thing-model",
"version": "1.0.2",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think name and version were wrong before in package-lock.json

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm true... not sure what really happened here

Copy link
Member

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we go for a release?

Comment on lines +2 to +3
"name": "@thingweb/thing-model",
"version": "1.0.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm true... not sure what really happened here

@danielpeintner
Copy link
Member Author

danielpeintner commented Jul 25, 2024

Should we go for a release?

Yes. Do you or shall I a?
I went ahead and published on NPM

@danielpeintner danielpeintner merged commit 16e13fa into eclipse-thingweb:main Jul 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporting the Resolver Interface
3 participants