Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmf: Support for configuration sources to create data providers #145

Closed
wants to merge 3 commits into from

Conversation

bhufmann
Copy link
Contributor

tmf: Support for configuration sources to create data providers

Updated org.eclipse.tracecompass.tmf.core.config extension point:

  • add data provider configuration source ITmfDataProviderConfigSource
  • make global ITmfConfigurationSource
  • Update TmfConfigurationSourceManager to handle update extension point

Introduce API ITmfDataProviderSource to implement for getting a list
of data provider descriptors for a given trace, data provider ID and
config ID. Implementers need to make sure that data provider factories
are registered to the DataProviderManager, that the new list are
also returned by DataProviderProvider#getDescriptors() and data
providers can be instantiated with it.

[Added] Support for configuration sources to create data providers
[Updated] org.eclipse.tracecompass.tmf.core.config extension point

This PR includes #144 and will rebased once dependent pull requests are merged.

Signed-off-by: Bernd Hufmann [email protected]

For schema specification see https://json-schema.org/

[Added] support for json-schema file to TmfConfigurationSourceType

Signed-off-by: Bernd Hufmann <[email protected]>
public static final String JSON_STRING_KEY = "--json-string-key--";

This is a compromise to not having to depend on a json parsing library
in the ITmfConfiguration interface.

[Added] API constant for retrieving json string from TmfConfiguration

Signed-off-by: Bernd Hufmann <[email protected]>
Updated org.eclipse.tracecompass.tmf.core.config extension point:
- add data provider configuration source ITmfDataProviderConfigSource
- make global ITmfConfigurationSource
- Update TmfConfigurationSourceManager to handle update extension point

Introduce API ITmfDataProviderSource to implement for getting a list
of data provider descriptors for a given trace, data provider ID and
config ID. Implementers need to make sure that data provider factories
are registered to the DataProviderManager, that the new list are
also returned by DataProviderProvider#getDescriptors() and data
providers can be instantiated with it.

[Added] Support for configuration sources to create data providers
[Updated] org.eclipse.tracecompass.tmf.core.config extension point

Signed-off-by: Bernd Hufmann <[email protected]>
@bhufmann
Copy link
Contributor Author

Closed in favour of #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant