Expose the clock and frequency in CtfTmfTrace #155
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frequency of the CtfTmfTrace is currently exposed in an indirect way using cyclesToNanos(). But sometimes there is the need to get direct frequency. This commit added public methods to get the direct frequency. [Added] public method to get clock info in CTFTmfTrace [Added] public method to get frequency in CTFClock Signed-off-by: Siwei Zhang <[email protected]>
siwei-zhang-work
force-pushed
the
expose-clock
branch
from
633fa1c
to
b6ada56
Compare
|
Hi Siwei, any thoughts on complementing getEnvironment with the frequency? It would require less code and no API changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frequency of the CtfTmfTrace is currently exposed in an indirect way using cyclesToNanos(). But sometimes there is the need to get direct frequency. This commit added public methods to get the direct frequency.
[Added] public method to get clock info in CTFTmfTrace
[Added] public method to get frequency in CTFClock