statesystem: Do not reduce time range condition for root nodes #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In HistoryBackEndIterator, do not reduce the time range condition for queuing children nodes when the current node is the root node, as its time range is not finalized during construction. Fixes eclipse-tracecompass#156 [Fixed] Do not reduce time range condition for root nodes Signed-off-by: Patrick Tasse <[email protected]>
arfio
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
If the node checked is the parent node, then it should not restrict the query as it will always match the last event timestamp. In the case of CTF, I noticed that the end time of the trace does not match the last event timestamp, that is due to the fact that the end timestamp of the trace is set according to packet end times which are usually "packet flushing timestamp".
In any case, this change looks good to me ! Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HistoryBackEndIterator, do not reduce the time range condition for queuing children nodes when the current node is the root node, as its time range is not finalized during construction.
Fixes #156
[Fixed] Do not reduce time range condition for root nodes