fix(bpdm-clearing): refactored legal name construction logic #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoprow
approved these changes
Sep 20, 2024
SujitMBRDI
force-pushed
the
fix/generation-of-legal-name
branch
from
962bf53
to
c76fab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, we have refactored the logic while constructing legal name for business partner.
This change will avoid setting empty value for legal name in clearning process so eventually, this will not allow sharing member to provide business partner data for their legal entity without nameparts or legal entity name(either of both must be shared while performing GR process).
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: