Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split business logic into processes #1006

Open
1 task
Phil91 opened this issue Sep 18, 2024 · 3 comments
Open
1 task

Split business logic into processes #1006

Phil91 opened this issue Sep 18, 2024 · 3 comments
Assignees
Labels
Back-End documentation Improvements or additions to documentation

Comments

@Phil91
Copy link
Member

Phil91 commented Sep 18, 2024

Description

To have the possibility to trigger transactional logic independently it makes sense to split those into separate processes / process steps

some time ago I did had a look at possible processes that make sense to be created as processes, those are:

InsertActiveAppUserRoleAsync
/api/apps/appchange/
{appId}/role/activeapp

ModifyUserRolesInternal
api/administration/user/owncompany/users/{companyUserId}/coreoffers/{offerId}/roles
api/administration/user/owncompany/users/{companyUserId}/apps/{appId}/roles
api/administration/user/app/{apiId}/roles (can that be removed?)

AddOwnCompanyUsersBusinessPartnerNumbersAsync
api/administration/user/owncompany/users/
{companyUserId}/businessPartnerNumbers

UpdateOwnUserDetails
api/administration/user/ownUser/{companyUserId}

-> UpdateSharedRealmUserAsync
DeleteOwnUserAsync
api/administration/user/ownUser/{companyUserId}

DeleteOwnUserBusinessPartnerNumbersAsync
/api/administration/user/owncompany/users/{companyUserId}/businessPartnerNumbers/{businessPartnerNumber}

DeleteOwnCompanyServiceAccountAsync
DELETE: api/administration/serviceaccount/owncompany/serviceaccounts/{serviceAccountId}

UpdateOwnCompanyServiceAccountDetailsAsync
PUT: api/administration/serviceaccount/owncompany/serviceaccounts/{serviceAccountId}
UpdateTenantUrlAsyncInternal
/api/apps/appchange/{appId}/subscription/{subscriptionId}/tenantUrl

AutoSetupOfferAsync (should be removed, since we already have the new autosetup process in place)
POST: /api/apps/autoSetup
POST: /api/service/autoSetup

UpdateSingleInstance + SetInstanceType
PUT: /api/apps/appreleaseprocess/instance-type/{appId}

ActivateSingleInstanceAppAsync
PUT: /api/apps/appreleaseprocess/{appId}/approveApp
PUT: /api/services/servicerelease/{serviceId}/approveService

CreateOwnCompanyIdentityProviderAsync
POST: api/administration/identityprovider/owncompany/identityproviders

DeleteCompanyIdentityProviderAsync
DELETE: api/administration/identityprovider/owncompany/identityproviders/{identityProviderId}

UploadOwnCompanyUsersIdentityProviderLinkDataAsync
POST: api/administration/identityprovider/owncompany/usersfile

CreateOwnCompanyServiceAccountAsync
POST: api/administration/serviceaccount/owncompany/serviceaccounts uses ServiceAccountCreation

ServiceAccountCreation -> maybe split in process steps
CreateOwnCompanyIdpUsersAsync -> same as for ServiceAccountCreation

since its already been some time since creating the list each entry should be checked again

Acceptance Criteria

  • issues are created
@Phil91 Phil91 added the enhancement New feature or request label Sep 18, 2024
@Phil91
Copy link
Member Author

Phil91 commented Sep 18, 2024

@MaximilianHauer as discussed in the meeting here is the list of endpoints which make sense to be split up

@evegufy @ntruchsess fyi

@MaximilianHauer
Copy link

@Phil91 as discussed please prepare some "sub-issues" do implement the processes step by step

@Phil91
Copy link
Member Author

Phil91 commented Oct 22, 2024

@MaximilianHauer see above links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Back-End documentation Improvements or additions to documentation
Projects
Status: IN PROGRESS
Development

No branches or pull requests

2 participants