-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(validation): update Company validation expression #1043
feat(validation): update Company validation expression #1043
Conversation
@typecastcloud please execute |
@MaximilianHauer technically the suggested rexexp looks fine. I verified it does what the comment in the code describes. Please confirm this may be merged (the associated ticket is already in progress with milestone assigned) |
@ntruchsess fine for me as we need to provide more international support and BPDM aligned with us that every request will be independently checked on their side and we would not provide any benefit with our restrictions to them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@typecastcloud please rebase on main and resolve the conflict in CHANGELOG.md (please consider to allow commiters to push to your repository or at least the open PR branches - if conflict-resolution is straightforward it's likely we cleanup such conflicts 'on-the-fly' while doing the review)
The Company validation expression in the ValidationExpressions class has been updated to support a wider range of characters, including special characters and non-Latin alphabets. This change ensures that the validation accurately captures company names from different languages and regions. Fixes: eclipse-tractusx/portal#360 Refs: eclipse-tractusx/portal-frontend-registration#250
56117ee
to
5615e71
Compare
Hi @ntruchsess, I always had this on as default and I don't know why this was not possible with this PR. Sorry! I was sick for the last few days. Rebased and comments are updated. |
Quality Gate passedIssues Measures |
Description
The Company validation expression in the ValidationExpressions class has been updated to support a wider range of characters, including special characters and non-Latin alphabets.
Why
This change ensures that the validation accurately captures company names from different languages and regions.
Issue
Fixes: eclipse-tractusx/portal#360
Refs: eclipse-tractusx/portal-frontend-registration#250
Checklist