Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(defaults): revert defaults set to empty string #151

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

oyo
Copy link
Contributor

@oyo oyo commented Apr 17, 2024

Description

Reverted defaults from empty string to undefined

Why

In the process of the framework upgrade some default values have been set to the empty string from before undefined. This caused issues with some api endpoints.

Issue

#123
eclipse-tractusx/portal-backend#639

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@oyo oyo requested a review from evegufy April 17, 2024 10:24
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@oyo oyo merged commit e73542f into dev Apr 17, 2024
8 checks passed
@oyo oyo deleted the fix/123/fix-default-values branch April 17, 2024 13:42
evegufy added a commit to eclipse-tractusx/portal that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants