Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed search string on clean search method #1293

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ss-nikunj
Copy link
Contributor

Description

  • The pageLoadingTable component has one method that will fire while pressing the cross icon. At that time we will set an empty string("") to search the text variable and the issue will be resolved.

Why

  • The user is not able to remove search text from the search input box even after clicking on the remove(cross icon) button. Users need to refresh the page to clean up the search box.

Issue

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have checked that new and existing tests pass locally with my changes

Changelog Entry

  • Fixed issue preventing search text from being cleared in App & Service Subscription without a page refresh. #370

@ss-nikunj ss-nikunj requested review from oyo and manojava-gk and removed request for oyo November 4, 2024 09:58
@ss-nikunj ss-nikunj self-assigned this Nov 4, 2024
Copy link

sonarcloud bot commented Nov 4, 2024

@ss-nikunj ss-nikunj marked this pull request as draft November 4, 2024 10:01
@ss-nikunj
Copy link
Contributor Author

ss-nikunj commented Nov 4, 2024

NOTE:

  • Currently, I have created a PR in the portal-shared-component library that PR will allow to pass the onCleanSearch method in the pageLoadingTable component. Before this PR we need to approve that PR.
  • I did not create any Github Issue in the portal-frontend repo for this PR. I have only created an issue on the portal-shared-component repo.

FYR: eclipse-tractusx/portal-shared-components#371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant