Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ErpAdapterService #419

Open
1 of 2 tasks
tom-rm-meyer-ISST opened this issue May 29, 2024 · 1 comment
Open
1 of 2 tasks

Refactor ErpAdapterService #419

tom-rm-meyer-ISST opened this issue May 29, 2024 · 1 comment
Labels

Comments

@tom-rm-meyer-ISST
Copy link
Contributor

tom-rm-meyer-ISST commented May 29, 2024

As Developer,
I want to clean up the ErpAdapterService,
so that we don't have technical debts.

Hints / Details

See findings in acceptance criteria

Outcome / Acceptance Criteria

Outcome

  • ...

Acceptance Criteria

  • DataInjectionCommandLineRunner: remove mock request
  • ErpAdapterController: add status codes 500 for any server side issue, 400 for bad request
  • Add tests for mapper
  • Double check that there is a test for the existing mapper if materialGlobalAssetId is empty
  • Align content of ErpAdapterRequest.requestType and add it as enumeration (with one entry), also check for version

Out of Scope

  • ...

Decomposed into

@eschrewe
Copy link
Contributor

Additional TODOS:

  • ItemStockErpAdapterService -> uncomment check for existing response
  • ErpAdapterContoller -> edit swagger descritption
  • ErpAdapterRequestService -> remove mock code from get method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants