-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup erpadapterrequest #578
chore: cleanup erpadapterrequest #578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot (also for fixing the PartnerControllerTest
)! Checked the issue again: Currently there is still the need to provide tests for the mapping of responses.
Note: as this PR is concise I could also split the issue into two tickets. Please let me know what you prefer :)
.../main/java/org/eclipse/tractusx/puris/backend/erpadapter/domain/model/ErpAdapterRequest.java
Show resolved
Hide resolved
...rg/eclipse/tractusx/puris/backend/erpadapter/logic/service/ErpAdapterRequestServiceTest.java
Outdated
Show resolved
Hide resolved
After taking a closer look, I noticed that the Asset Type validation was not working correctly in the Unit tests, so I did some refactoring here. Regarding the issue of adding additional tests for the mapping of responses, I think it'd be best if we wait for detailed feedback from the other team, that is currently supposed to work on the erp-adapter project (Gerhard). Maybe they come up with a request to change to API a bit, or something like that... |
One could argue for both as likely changes won't be fundamental (I expect). As proposed I've split #419 into #584 and #583. This issue solves #584 Is this pr ready for review? :) |
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for contributing!
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: