-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci/docker #18
Ci/docker #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KICS found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to update the DEPENDENCIES_BACKEND
. Based on the pipeline, the file isn't up to date.
Updated dependency file using full scope |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, since the failed quality check pipeline is addressed in eclipse-tractusx/sig-infra#230
Description
The docker files used hard-wired addresses for common environments. Both, frontend and backend, can now use environment variables instead:
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: