Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/docker #18

Merged
merged 25 commits into from
Aug 18, 2023
Merged

Ci/docker #18

merged 25 commits into from
Aug 18, 2023

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

Description

The docker files used hard-wired addresses for common environments. Both, frontend and backend, can now use environment variables instead:

  • ci: Dockerfile for frontend uses substring mechanism to update environment variables in built files
  • ci: Dockerfile for frontend uses nginx unpriviledged
  • ci: Dockerfile for backend now can use environment variables for application.properties
  • fix: application.properties were outdated.
  • ci: added docker-compose for both
  • docs: updated INSTALL.mds

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KICS found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

frontend/start-nginx.sh Show resolved Hide resolved
frontend/replace_env.sh Outdated Show resolved Hide resolved
Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update the DEPENDENCIES_BACKEND. Based on the pipeline, the file isn't up to date.

@tom-rm-meyer-ISST
Copy link
Contributor Author

Updated dependency file using full scope

Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since the failed quality check pipeline is addressed in eclipse-tractusx/sig-infra#230

@mhellmeier mhellmeier merged commit 89bfcc9 into eclipse-tractusx:main Aug 18, 2023
7 of 8 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the ci/docker branch August 29, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants