Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/material service frontend #21

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Refactor/material service frontend #21

merged 4 commits into from
Aug 18, 2023

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Aug 18, 2023 •
edited
Loading

Description

PR combines changes made in PR#20 on logic layer in backend with the frontend:

  • refactor: exchange api (request and response) uses m:n material model
  • refactor: exchange api (request and response) uses business identifiers
  • refactor: frontend uses backend accordingly.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@tom-rm-meyer-ISST tom-rm-meyer-ISST marked this pull request as ready for review August 18, 2023 15:14
mhellmeier
mhellmeier approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since the failed quality check pipeline is addressed in eclipse-tractusx/sig-infra#230

@mhellmeier mhellmeier merged commit 3f3e74a into eclipse-tractusx:main Aug 18, 2023
7 of 8 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the refactor/material-service-frontend branch August 29, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhellmeier mhellmeier mhellmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-rm-meyer-ISST @mhellmeier