-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci: docker compose for local test scenario #24
Ci: docker compose for local test scenario #24
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KICS found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
0f7a43a
to
c9e8572
Compare
c9e8572
to
3db608a
Compare
Quality check still fails because we need to incorporate this issue: eclipse-tractusx/sig-infra#230 |
Updated license headers. |
Regarding postgresql, remember to have a look at eclipse-tractusx/sig-infra#308 |
# Conflicts: # backend/src/main/java/org/eclipse/tractusx/puris/backend/stock/controller/ProductStockRequestApiController.java # backend/src/main/java/org/eclipse/tractusx/puris/backend/stock/logic/service/ProductStockRequestApiServiceImpl.java
Regarding quality checks: The TRG for base images only applies to publishing images. As we use it locally for integration test, it's fine. I added the exclusion already to the metadata file. As soon as the reusable workflow is ready, it will pass. See here. |
Release guideline workflow has been updated. Everything works out now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different changes in the docker setup are necessary to get it working. I can fix it for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, since it is only a local deployment for testing purposes and the KICS issues are addressed in #79
Description
Introduced a docker-compose for local test demonstration. Spins up following containers needed for edc 0.3.0
It provides additional setup scripts and configuration for the given scenario.
Please note: fixed the secrets and then squashed. Tried multiple times as one path was seen as secret. Externalized all potential secrets into an .env
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: