Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/dynamic supplier dashboard #25

Merged
merged 5 commits into from
Aug 31, 2023
Merged

Feat/dynamic supplier dashboard #25

merged 5 commits into from
Aug 31, 2023

Conversation

PaMarzec
Copy link
Contributor

Description

  • changed the dashboard to be dynamic
  • added mock data for "customer", "material" and "your stock"
  • added the changing of backgroundcolor to red if production is lower than total demand

tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update small fix and then let me know. For the next time: when doing a PR, please don't remove the second part of the PR. It reminds you of then performing the dashtool check and checking for missing license headers. If you did not check that, please also do :)

frontend/src/views/SupplierDashboard.vue Outdated Show resolved Hide resolved
tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! @mhellmeier please merge.

mhellmeier
mhellmeier approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since the failed Q-Gate pipeline is already addressed.

@mhellmeier mhellmeier merged commit e532175 into eclipse-tractusx:main Aug 31, 2023
7 of 8 checks passed
@PaMarzec PaMarzec deleted the feat/dynamicSupplierDashboard branch September 4, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

@mhellmeier mhellmeier mhellmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PaMarzec @mhellmeier @tom-rm-meyer-ISST