-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: base64 encoding #512
fix: base64 encoding #512
Conversation
...eclipse/tractusx/puris/backend/masterdata/controller/MaterialPartnerRelationsController.java
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing. Beside the one comment, please also check on the following:
- Tests are failing for MaterialPartnerRelationsControllerTest and MaterialControllerTest.getMaterialTest()
- Controller for Days of supply also has unencoded material numbers
- Postman collection needs an update to use scripted value
- opening stock view throws an error (StockViewController.getCustomerProductStocks(StockViewController.java:476)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! Beside one test in the postman colleciton failing, opening Stock View, selecting tab Products leads to an error:
customer-backend | java.lang.IllegalArgumentException: Last unit does not have enough valid bits
customer-backend | at java.base/java.util.Base64$Decoder.decode0(Unknown Source) ~[na:na]
customer-backend | at java.base/java.util.Base64$Decoder.decode(Unknown Source) ~[na:na]
customer-backend | at java.base/java.util.Base64$Decoder.decode(Unknown Source) ~[na:na]
customer-backend | at org.eclipse.tractusx.puris.backend.stock.controller.StockViewController.getSupplierMaterialStocks(StockViewController.java:438) ~[!/:2.0.2]
customer-backend | at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(Unknown Source) ~[na:na]
customer-backend | at java.base/java.lang.reflect.Method.invoke(Unknown Source) ~[na:na]
Please check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Postman collection works fine! Please check for the exception thrown when opening the stock view.
...d/src/main/java/org/eclipse/tractusx/puris/backend/stock/controller/StockViewController.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pushed small coalescing change. Thanks for your work!
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: