feat: add bruno int test collection #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-rm-meyer-ISST
requested changes
Aug 19, 2024
There was a problem hiding this comment.
Thanks a lot! Works great. I checked both, the GUI & the CLI usage and it works fine!
Had a few minor findings.
I already checked the license for the CLI and filed one IP check: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15955
Please handle comments. I'll then file a request at the EF.
...01-MAD/01_02-Operational Data/Supplier/Stock/Get Semiconductor Product Stocks -Supplier-.bru
Outdated
Show resolved
Hide resolved
...01-MAD/01_02-Operational Data/Supplier/Stock/Get Semiconductor Product Stocks -Supplier-.bru
Outdated
Show resolved
Hide resolved
local/bruno/puris-integration-test/environments/puris integration test env.bru
Outdated
Show resolved
Hide resolved
local/bruno/puris-integration-test/environments/puris integration test env.bru
Show resolved
Hide resolved
...puris-integration-test/Test_01-MAD/01_01-Init/Customer/MAD/Get Material Partner Mappings.bru
Outdated
Show resolved
Hide resolved
...ation-test/Test_01-MAD/01_01-Init/Supplier/MAD/Add New Site to Supplier Partner -MySelf-.bru
Outdated
Show resolved
Hide resolved
...puris-integration-test/Test_01-MAD/01_01-Init/Supplier/MAD/Get Material Partner Mappings.bru
Outdated
Show resolved
Hide resolved
...t/Test_01-MAD/01_02-Operational Data/Supplier/Delivery/Get Delivery 5 days Semiconductor.bru
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
LGTM! Thanks a lot.
Regarding Trufflehog i raised PR#555.
As we got plenty lines of code I raised an EF IP issue. I will approve and merge as soon as we got the response :)
tom-rm-meyer-ISST
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: